DO NOT MERGE
DO NOT MERGE
Merged
You're viewing a single thread.
33 comments
-
Why did they submit this as a pull request in the first place? Just commit it to a WIP branch until it’s ready to merge. Am I missing something?
-
Probably to get some other benefitof the PR system, such as CI tests
-
Does gerrit have a draft state? In azure devops you can mark PR as draft , won't trigger any builds but you can still start them manually
-
manually
This is probably why the dev created a PR, less clicks
-
I don’t remember if it did when I used it. Our convention was to -2 your own change until it was ready to go 😅
-
-
-
I do this often. It's useful if you want to send it to your coworker for some early feedback or as others have said, have the CI run
-
It's been a while since I've worked with AOSP, but I had always understood it to be some weird shit with Google's internal processes. The "do not merge" commits are all over the AOSP, or at least they used to be.
-
33 comments